Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : Carousel UI changed #328

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

praptisharma28
Copy link
Contributor

closes #220

@shelcia , it took me around 1.5 hours to do that. A "hard" difficulty level tag would be appreciated😊 + one of my old PR I did for you is not showing on m dashboard still. Also plz don't forget to add the iwoc24 tag.

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dynamic-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 2:34pm

@praptisharma28
Copy link
Contributor Author

@shelcia did u hv a look at it ?

@shelcia shelcia self-requested a review January 24, 2024 03:34
Copy link
Owner

@shelcia shelcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praptisharma28
Copy link
Contributor Author

okay @shelcia

@praptisharma28
Copy link
Contributor Author

Done @shelcia , please add the tags on the PR.

Copy link
Owner

@shelcia shelcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

home.scss should be a module, _home.scss change it to this

@shelcia shelcia self-requested a review January 25, 2024 04:42
Copy link
Owner

@shelcia shelcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

home.scss should be module , _home.scss

@shelcia
Copy link
Owner

shelcia commented Jan 25, 2024

Also deployment
failure,
Error: Preprocessor dependency "sass" not found. Did you install it? Try yarn add -D sass.

03:59:04.961 | at loadPreprocessor (file:///vercel/path0/node_modules/vite/dist/node/chunks/dep-52909643.js:39304:19)
03:59:04.961 | at scss (file:///vercel/path0/node_modules/vite/dist/node/chunks/dep-52909643.js:39345:20)
03:59:04.961 | at compileCSSPreprocessors (file:///vercel/path0/node_modules/vite/dist/node/chunks/dep-52909643.js:38770:36)
03:59:04.961 | at compileCSS (file:///vercel/path0/node_modules/vite/dist/node/chunks/dep-52909643.js:38820:42)
03:59:04.961 | at async Object.transform (file:///vercel/path0/node_modules/vite/dist/node/chunks/dep-52909643.js:38300:56)
03:59:04.962 | at async transform (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:24449:16)
03:59:04.962 | at async ModuleLoader.addModuleSource (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:24649:30)
03:59:04.985 | error Command failed with exit code 1.

@shelcia
Copy link
Owner

shelcia commented Jan 25, 2024

https://marketplace.visualstudio.com/items?itemName=ritwickdey.live-sass install this on VS code and the sass as module and compile it. https://sass-lang.com/

@praptisharma28
Copy link
Contributor Author

done @

closes #220

@shelcia , it took me around 1.5 hours to do that. A "hard" difficulty level tag would be appreciated😊 + one of my old PR I did for you is not showing on m dashboard still. Also plz don't forget to add the iwoc24 tag.

Everything done @shelcia have a look.

@shelcia
Copy link
Owner

shelcia commented Jan 28, 2024

Screenshot 2024-01-27 at 11 37 19 PM it looks like this

@praptisharma28
Copy link
Contributor Author

Yes @shelcia this is what I did. The more the templates are the most beautiful it will look. I hope PR gets merged thankyou!

@shelcia
Copy link
Owner

shelcia commented Jan 28, 2024

@praptisharma28 I am sorry but they look skewed unfortunately. I can't accept this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Better display of Templates instead of Carousel on Homepage
2 participants