-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement : Carousel UI changed #328
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@shelcia did u hv a look at it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add styling here in sass https://github.com/shelcia/dynamic-portfolio/tree/master/src/styles/components
okay @shelcia |
Done @shelcia , please add the tags on the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
home.scss should be a module, _home.scss change it to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
home.scss should be module , _home.scss
Also deployment
|
https://marketplace.visualstudio.com/items?itemName=ritwickdey.live-sass install this on VS code and the sass as module and compile it. https://sass-lang.com/ |
closes shelcia#220
Yes @shelcia this is what I did. The more the templates are the most beautiful it will look. I hope PR gets merged thankyou! |
@praptisharma28 I am sorry but they look skewed unfortunately. I can't accept this |
closes #220
@shelcia , it took me around 1.5 hours to do that. A "hard" difficulty level tag would be appreciated😊 + one of my old PR I did for you is not showing on m dashboard still. Also plz don't forget to add the iwoc24 tag.