Correctly handle unicode chapters #58
Conversation
|
Hi @throwawayay, could you provide some unicode chapter files for me to test with? |
|
Note that my approach is not the cleanest but it does end up needing the smallest code change. I've attached two sample files (in the "simple") chapter format. P.S. Related to internationalization - there's another issue where pymkv cannot set the character encoding on subtitles ( |
|
Thanks for the files, I’ll take a look here in the next few days. Also, that would be great if you can open an issue with a detailed description of the issue regarding internationalization. |
| if self._chapters_file is not None: | ||
| command.extend(['--chapter-charset UTF-8 --chapters', self._chapters_file]) | ||
| if self._chapter_language is not None: | ||
| command.extend(['--chapter-language', self._chapter_language]) |
There was a problem hiding this comment.
Instead of combining the --chapter-charset option here with the --chapters option, lets give the user more control by creating a new self._chapters_charset variable that is stored in the MKVFile object. It can be initialized to None when the object is created and have property methods similar to the chapter language property.
Also fixes potential bug of
Error: '--chapter-charset' must be given before '--chapters' in '--chapter-charset UTF-8'.