Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth support for the frontend #466

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

sarge
Copy link

@sarge sarge commented Nov 20, 2022

ADO card: ☑️ AB#XXXX

Elab notes/AC: 📃 Google Docs

Designs:

Description of work

Allow SSO to feedback if the login failed due the email not being verified or if MFA was required.

Edge cases/Caveats/Known issues

Config settings/Toggles required for the feature to work

Related PRs

Any PRs which this PR depends on

  • Relish?
  • Kibble?
  • APIs?

Any PRs dependent on this one

  • Relish?
  • Kibble?
  • APIs?

Affected Clients

  • All clients who use Kibble
  • Client 1
  • Client 2

Checklist

  • CI tests are passing Github actions (inc. linting)
  • Key areas of the feature outlined for context and testing
  • If there are designs for this work are they noted here and in the ADO card
  • Design review
  • Have checked this at multiple screen resolutions and range of browsers
  • Moved ADO card to Dev/done, checked link to Github, tagged "Review"
  • Updated changelog (if applicable)
  • I promise to document any new feature toggles/configurations in the appropriate documentation

@sarge sarge requested review from additiverich and PeculiarGoat and removed request for additiverich November 24, 2022 01:15
site/ar_LB.all.json Outdated Show resolved Hide resolved
site/ca_ES.all.json Outdated Show resolved Hide resolved
site/sr_SR.all.json Outdated Show resolved Hide resolved
Copy link
Contributor

@PeculiarGoat PeculiarGoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of bits to look at but overall seems good!

@sarge sarge added the blocked label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants