Alignment fix ups for sliders/collections/library pages #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a -5px margin being added to the first child of a slider or collection in order to counter-style the padding and align it with titles -- except this looks goofy when it wraps because the posters don't line up in a grid. Instead, this applies the negative margin to the whole container.
It gets too w i d e on big screens and looks silly.
The overall size isn't changed, but it moves the text closer to the poster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection views had a negative margin hack that was causing grid rows to not line up -- it was adding -5px margin to the first child of the collection to counteract the 5px padding to align the poster with the titles, but this caused subsequent rows to be misaligned.
I've also tweaked the caption padding to move the text closer to the poster. This makes the visual grouping clearer when there are multiple rows -- the text used to sit awkwardly close to the middle.
Another fix was adding a max-width to the library and wishlist pages to avoid the items spreading out if you have a really wide window.