Skip to content

Commit

Permalink
[CLI] add new valid search attribute key cases for context header ind…
Browse files Browse the repository at this point in the history
…exing in visibility
  • Loading branch information
shijiesheng committed Jun 24, 2024
1 parent 83ebf7a commit 4dfd72e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tools/cli/admin_cluster_commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import (

// An indirection for the prompt function so that it can be mocked in the unit tests
var promptFn = prompt
var validSearchAttributeKey = regexp.MustCompile(`^[a-zA-Z][a-zA-Z_0-9]*$`)
var validSearchAttributeKey = regexp.MustCompile(`^[a-zA-Z][a-zA-Z_.-0-9]*$`)

// AdminAddSearchAttribute to whitelist search attribute
func AdminAddSearchAttribute(c *cli.Context) {
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/admin_cluster_commands_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ func TestValidSearchAttributeKey(t *testing.T) {
assert.NoError(t, validateSearchAttributeKey("cityId"))
assert.NoError(t, validateSearchAttributeKey("paymentProfileUUID"))
assert.NoError(t, validateSearchAttributeKey("job_type"))
assert.NoError(t, validateSearchAttributeKey("Header.ctx-tenancy"))

assert.Error(t, validateSearchAttributeKey("payments-biling-invoices-TransactionUUID"))
assert.Error(t, validateSearchAttributeKey("9lives"))
assert.Error(t, validateSearchAttributeKey("tax%"))
}

0 comments on commit 4dfd72e

Please sign in to comment.