Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change indicator for volume and last price #214

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Conversation

alichtman
Copy link
Collaborator

@alichtman alichtman commented Dec 18, 2018

Progress on #208. Can be merged as is, but...

TODO: Should add indicator flags to fetch_blockchain_data() in retriever.py and add a method for reformatting the blockchain network data in index.js, which should be called here: let blockchainData = blockchainJSON.data;

@shobrook pretty sure some modifications have to be made in the engine to pass this data back. Gonna let you make them since you landscaped that and know what's going on. I can add the frontend formatting for the table once those flags are being passed in the data files.

@alichtman alichtman changed the title Add change indicator for volume and last price WIP: Add change indicator for volume and last price Dec 18, 2018
@alichtman alichtman changed the title WIP: Add change indicator for volume and last price WIP: Add change indicator for volume and last price + network data Dec 18, 2018
@alichtman alichtman changed the title WIP: Add change indicator for volume and last price + network data Add change indicator for volume and last price Dec 19, 2018
@alichtman alichtman merged commit 1245aaf into master Dec 19, 2018
@alichtman alichtman deleted the change-indicators branch January 8, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants