-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deep copy so that all arguments are copied by value (Sourcery refactored) #67
base: master
Are you sure you want to change the base?
Conversation
assert not (_fields is None and exclude is None), ( | ||
assert _fields is not None or exclude is not None, ( | ||
"Creating a ModelSerializer without either the 'fields' attribute " | ||
"or the 'exclude' attribute has been deprecated since 3.3.0, " | ||
"and is now disallowed. Add an explicit fields = '__all__' to the " | ||
"{serializer_class} serializer.".format(serializer_class=self.__class__.__name__), | ||
"{serializer_class} serializer.".format( | ||
serializer_class=self.__class__.__name__ | ||
), | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function ModelSerializer.get_field_names
refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan
)
backrefs = set() | ||
for key, rel in target_model_info.relationships.items(): | ||
if rel.related_model == self.model: | ||
backrefs.add(key) | ||
backrefs = { | ||
key | ||
for key, rel in target_model_info.relationships.items() | ||
if rel.related_model == self.model | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function ModelSerializer.get_nested_relationship_fields
refactored with the following changes:
- Convert for loop into set comprehension (
set-comprehension
)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.06%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Pull Request #66 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin: