Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure URL segment field type before using its API, and add docs around subsite and fluent domain compatibility #418

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Ensure URL segment field type before using its API, and add docs around subsite and fluent domain compatibility #418

merged 3 commits into from
Jun 5, 2019

Conversation

robbieaverill
Copy link
Contributor

Issue: #416

@robbieaverill robbieaverill mentioned this pull request May 30, 2019
Open
@robbieaverill robbieaverill changed the base branch from 2.3 to 2.2 May 30, 2019 23:28
@robbieaverill robbieaverill reopened this May 30, 2019
@robbieaverill
Copy link
Contributor Author

Re-targetted at 2.2 because 2.3 requires SilverStripe 4.4

Cheddam
Cheddam approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@Cheddam Cheddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple of tiny tweaks to the docs.

docs/en/introduction.md Outdated Show resolved Hide resolved
docs/en/introduction.md Outdated Show resolved Hide resolved
@robbieaverill
DOCS Fix typos
f650382 
[ci skip]

Co-Authored-By: Garion Herman <garion@silverstripe.com>
@Cheddam Cheddam merged commit 5c4a655 into silverstripe:2.2 Jun 5, 2019
@robbieaverill robbieaverill deleted the pulls/2.3/fluent-domain-docs branch June 5, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheddam Cheddam Cheddam approved these changes

Assignees
No one assigned
Labels
affects/v4 type/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbieaverill @Cheddam