Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NexusDetector: Fixed type on shape #2352

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Dec 6, 2024

Not sure this is the right way to fix it, but this PR workaround #2351: by making sure the shape is a tuple of Python int, this PR fixes the export of the Worker config as a JSON file.

Related to #2351

@t20100 t20100 requested a review from kif December 6, 2024 15:42
Copy link
Member

@kif kif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting the bug & fixing it

@kif kif merged commit 274f544 into silx-kit:main Dec 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants