Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New alias detail page #1691

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

D-Bao
Copy link
Contributor

@D-Bao D-Bao commented Apr 14, 2023

This new alias detail page shows the information for 1 alias, the URL of the page being /dashboard/aliases/{alias_id}. It replaces the usage of dashboard/?highlight_alias_id={alias_id} for some URL redirections like from the alias transfer page and the refused email page. We may also combine this new page with the alias log + contact manager pages in the future.

@nguyenkims
Copy link
Contributor

Hey some feedbacks about the layout

CleanShot 2023-04-16 at 22 23 10@2x

I think when alias log and contact manager can be added to the right side panel, similarly to the domain detail page:
image

@nguyenkims
Copy link
Contributor

@D-Bao
CleanShot 2023-04-22 at 21 17 43@2x

@D-Bao
Copy link
Contributor Author

D-Bao commented Apr 27, 2023

Actually I planned to remove the text "0 forwarded... See all" once alias log is added to the right side panel.
But it's true for the moment it creates redundant info, do you want me to temporarily put it above "Created 3 months ago" and remove "No emails received..."?

@nguyenkims
Copy link
Contributor

Yes until we have the alias log page easily accessible, it's better to put this info below the alias.

Actually I planned to remove the text "0 forwarded... See all" once alias log is added to the right side panel. But it's true for the moment it creates redundant info, do you want me to temporarily put it above "Created 3 months ago" and remove "No emails received..."?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants