Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arm64 builds #2310

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

martadams89
Copy link
Contributor

This PR adds arm64 builds back in.

I forked the repo and tested it against my own and appeared to run as expected.

@martadams89
Copy link
Contributor Author

@acasajus @cquintana92 @nguyenkims can someone review this? It resolves #1566 (comment)

@acasajus
Copy link
Collaborator

acasajus commented Nov 8, 2024

We disabled the arm builds because there were some dependencies that were making the tests really flaky and that failed the production deployments. As soon as we fix those dependencies we will enable arm back.

@ctrl-i
Copy link

ctrl-i commented Nov 23, 2024

We disabled the arm builds because there were some dependencies that were making the tests really flaky and that failed the production deployments. As soon as we fix those dependencies we will enable arm back.

Any progress on this? If you told us which dependencies were making which test flaky we might be able to help out. I haven't noticed any flakiness in my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants