Fix comments

sinch · Aug 19, 2024 · 8443611 · 8443611
1 parent 1dbf86d
commit 8443611
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/packages/sdk-client/src/plugins/exception/exception.response.ts b/packages/sdk-client/src/plugins/exception/exception.response.ts
@@ -48,7 +48,10 @@ export class ExceptionResponse<
           );
         } else if (!res) {
           res = {} as V;
-          if (context.response.status !== 204 && context.response.status !== 200) {
+          if (context.response.status !== 204
+            && context.response.status !== 200
+            && context.response.status !== 202
+          ) {
             res = {} as V;
             error = new EmptyResponseError<V>(
               context.response.statusText,

diff --git a/packages/sms/tests/rest/v1/batches/batches.steps.ts b/packages/sms/tests/rest/v1/batches/batches.steps.ts
@@ -10,6 +10,7 @@ let listResponse: PageResult<Sms.SendSMSResponse>;
 let batchesList: Sms.SendSMSResponse[];
 let pagesIteration: number;
 let batch: Sms.SendSMSResponse;
+let deliveryFeedbackResponse: void;
 
 Given('the SMS service "Batches" is available', () => {
   const smsService = new SmsService({
@@ -239,3 +240,18 @@ Then('the response contains the SMS batch details with a cancelled status', () =
   assert.equal(batch.id, '01W4FFL35P4NC4K35SMSBATCH1');
   assert.equal(batch.canceled, true);
 });
+
+When('I send a request to send delivery feedbacks', async () => {
+  deliveryFeedbackResponse = await batchesApi.sendDeliveryFeedback({
+    batch_id: '01W4FFL35P4NC4K35SMSBATCH1',
+    deliveryFeedbackRequestBody: {
+      recipients: [
+        '+12017777777',
+      ],
+    },
+  });
+});
+
+Then('the delivery feedback response contains no data', () => {
+  assert.deepEqual(deliveryFeedbackResponse, {});
+});