DEVEXP-488: Move AvailableNumbers and ActiveNumbers related operations #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asein-sinch
requested review from
JPPortier,
krogers0607,
Dovchik and
650elx
as code owners
JPPortier
reviewed
Jul 25, 2024
| import { PageResult } from '@sinch/sdk-client'; | ||
| import assert from 'assert'; | ||
|
|
||
| let activeNumberApi: ActiveNumberApi; | ||
| let numbersService: NumbersService; | ||
| let listActiveNumbersResponse: PageResult<Numbers.ActiveNumber>; | ||
| const activeNumbersList: Numbers.ActiveNumber[] = []; | ||
| let activeNumber: Numbers.ActiveNumber; | ||
| let error: any; | ||
|
|
||
| Given('the Numbers service "Active Number" is available', function () { |
There was a problem hiding this comment.
Finally, from anE2E point of view: there is no more "Active Number" (nor "Available") to wait for.
Just the Numbers service
There was a problem hiding this comment.
Right, I'll fix that!
There was a problem hiding this comment.
Fix is made, with the associated feature file on the mockserver repo
There was a problem hiding this comment.
The build will need to be re-triggered when the new feature file is merged, otherwise cucumber complains the steps are not defined
JPPortier
approved these changes
Jul 26, 2024
asein-sinch
deleted the
DEVEXP-488_Move-AvailableNumbers-and-ActiveNumbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.