DEVEXP-321: Add sub methods for messages and events #35
Conversation
| } else if ('choice_message' in translation) { | ||
| return { | ||
| type: MessageType.CHOICE, | ||
| content: translation.choice_message, | ||
| }; | ||
| } else if ('carousel_message' in translation) { | ||
| } else if ('contact_info_message' in translation) { |
There was a problem hiding this comment.
OAS file do not contains contact_info_message
Did we sent feedback ?
There was a problem hiding this comment.
They did an update in the conversation file but not yet in the template file. I hope it will follow soon
| @@ -3,7 +3,7 @@ import { Recipient } from '../recipient'; | |||
| /** | |||
| * An CapabilityResponse contains the identity of the recipient for which will be perform a capability lookup. | |||
| */ | |||
| export interface QueryCapabilityResponse { | |||
| export interface LookupCapabilityResponse { | |||
There was a problem hiding this comment.
My own interest here 😇
We could imagine having a mapping table to share same naming across SDKs (oas generator tool could be a good location)
There was a problem hiding this comment.
Yes, as soon as it is ready, it will be more convenient than a confluence page 👍
| */ | ||
| public async getChannelProfile(data: GetChannelProfileRequestData): Promise<GetChannelProfileResponse> { | ||
| public async getChannelProfile(data: GetChannelProfileRequestData<Recipient>): Promise<GetChannelProfileResponse> { |
There was a problem hiding this comment.
No dedicated function name usage? (getChannelProfileByContactId and getChannelProfileByChannelIdentity)
There was a problem hiding this comment.
No indeed. I've used instead another pattern for the recipient type with the type parameter <Recipient>.
As this API defines other more important variations for messages and events, it's better not to create too many methods
…ipient-categories
asein-sinch
deleted the
DEVEXP-321_Derivate-methods-according-to-recipient-categories
branch
Interface refactoring:
Refactor mocks for tests