Feat: Add randomize option #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Apr 1, 2024
| }); | ||
| ``` | ||
| */ | ||
| readonly randomize?: boolean; |
There was a problem hiding this comment.
The option is coming from the retry package, so this needs to be added to @types/retry.
| /** | ||
| Decide if a random delay should be introduced between retries. | ||
| Enabling this option adds variability to the retry strategy, helping to distribute load peaks and reduce contention. | ||
| If set to `true`, a random delay will be introduced between each retry attempt. |
There was a problem hiding this comment.
I needs to say what the random delay range could be.
| const result = await pRetry(run, { | ||
| randomize: true | ||
| }); | ||
| ``` |
There was a problem hiding this comment.
This is already covered by:
Options are passed to the
retrymodule.
|
@sindresorhus Thank you for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development description