-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Historical coverage feature / v0.5.0 #386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h cems and eia923
Expand historical coverage pre-2019
…ubplant level only (#361)
…add/format docstrings, add missing typehints
…dd missing typehints
Add 2005, 2006 and 2007 years
…ocation Calculate electric_allocation_factor by subplant
Compress OGE Outputs
… typehints, add/format docstrings
Add geographical information to the plant static attributes data frame
Add geopy to pyproject dependencies
Add backstop sulfur content percentage for years 2005, 2006 and 2007
Update warning message about validated years
Discard non-operational generators when calculating plant capacity
…shift_gtn Revert removal of GTN shift factors
Update to 0.5.0 and change s3 directory
Fix missing capacity in plant static attributes
Update documentation
rouille
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. In the methodological changes/updtaes section of the PR description (or in the release notes), we can add the updates to the calculation of the sulfur content (national to state level backstop) and the filling of missing values for years 2005-2007 (use 2008-2012 data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR merges several months of work to expand the historical coverage of the data back to 2005. All of this work has been previously reviewed.
NOTE: I am proposing that we merge directly into
main
and then rebase development to match main once v0.5.0 is released.Draft release notes
Expands historical coverage of OGE to include monthly and annual data for 2005-2018 (#295 and #362)
In addition to the new data, users should expect changes to the existing 2019-2022 data: NOx and SO2 totals may change for some plants, net generation totals may change for some plants, data may change for CHP plants (see the "methodological updates" section for more details)
Inputs:
energy_source_groups
file, and theutility_name_ba_code_map
file (Update Energy Source Codes and Utility Name Map #374), andepa_eia_crosswalk_manual
(Update manual epa eia crosswalk reference table #372), andemission_factors_for_co2_ch4_n2o
(update co2 factors based on manual energy source group updates #377)Outputs
outputs/
directory are now saved as compressed.csv.zip
files instead of.csv
files. This reduces the disk space of the outputs folder from approximately 16GB to 2.5GB. (Compress OGE Outputs #366)outputs/annual_generation_averages_by_fuel
file were not being calculated correctlyMethodological updates
Other fixes