Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical coverage feature / v0.5.0 #386

Merged
merged 97 commits into from
Aug 1, 2024
Merged

Conversation

grgmiller
Copy link
Collaborator

@grgmiller grgmiller commented Jul 31, 2024

Purpose

This PR merges several months of work to expand the historical coverage of the data back to 2005. All of this work has been previously reviewed.

NOTE: I am proposing that we merge directly into main and then rebase development to match main once v0.5.0 is released.

Draft release notes
Expands historical coverage of OGE to include monthly and annual data for 2005-2018 (#295 and #362)

In addition to the new data, users should expect changes to the existing 2019-2022 data: NOx and SO2 totals may change for some plants, net generation totals may change for some plants, data may change for CHP plants (see the "methodological updates" section for more details)

Inputs:

Outputs

Methodological updates

  • When calculating the electric allocation factors for combined heat and power (CHP) plants, we previously were calculating this at the generator level, which was introducing bugs for certain combined cycle units when fuel and generation is reported for different generators at the same subplant. We now calculate this factor at the subplant level (Calculate electric_allocation_factor by subplant #363)
  • Fixes several bugs with the gross-to-net generation conversions where anomalous fleet-average ratios were being introduced, and default factors were not being mapped to certain generators. Also fixed a bug where GTN ratios were being calculated where there was missing gross generation or net generation data. (Fix issues with anomalous gross to net conversions #370, Correct Gross to Net Generation Bugs #375, Revert removal of GTN shift factors #383)
  • Updates uncontrolled NOx and SO2 factors to align assumptions with those used by the EIA Electric Power Annual, and to fix a bug where we were adjusting the SO2 values for fluidized bed boilers, even though the control efficiencies are already incorporated into the uncontrolled emission factors (Update Uncontrolled NOx and SO2 factors #373). In addition, because fuel sulfur content data is not available pre-2008, we use sulfur content values averaged from 2008-2012 to backfill the missing data. When calculating backstop values for missing values in any year, we now use state-specific values (rather than national-average) to reflect differences in the sulfur contents of fuels being delivered in specific parts of the country (Add backstop sulfur content percentage for years 2005, 2006 and 2007  #376)

Other fixes

grgmiller and others added 30 commits May 16, 2024 10:40
…add/format docstrings, add missing typehints
…ocation

Calculate electric_allocation_factor by subplant
Add geographical information to the plant static attributes data frame
grgmiller and others added 25 commits July 9, 2024 10:44
Add geopy to pyproject dependencies
Add backstop sulfur content percentage for years 2005, 2006 and 2007
Update warning message about validated years
Discard non-operational generators when calculating plant capacity
…shift_gtn

Revert removal of GTN shift factors
Fix missing capacity in plant static attributes
@grgmiller grgmiller marked this pull request as ready for review August 1, 2024 01:13
@grgmiller grgmiller requested a review from rouille August 1, 2024 01:13
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. In the methodological changes/updtaes section of the PR description (or in the release notes), we can add the updates to the calculation of the sulfur content (national to state level backstop) and the filling of missing values for years 2005-2007 (use 2008-2012 data)

@grgmiller grgmiller merged commit 4ac110c into main Aug 1, 2024
2 checks passed
@grgmiller grgmiller deleted the historical_coverage_feature branch August 1, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants