-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Перенос http-toolkit в github #1
Conversation
PI-544 Отделить код специфичный для Контура See merge request py-libs/kontur_http_toolkit_core!1
Есть ощущение, что стоит избавиться от директории |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Два вопроса:
- Нужен ли пример здесь для opentelemetry?
- Если да, то нужно проверить этот пример)
.github/workflows/build-and-push.yml
Outdated
runs-on: ubuntu-latest | ||
environment: | ||
name: pypi | ||
url: https://pypi.org/p/kontur_http_toolkit_core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
нужно подумать над названием package. Предлагаю сделать просто http_toolkit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
и что, в следующий раз менять все зависимости?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
для контуровских репозиториев у нас же останется kontur_http_toolkit с специфичным кодом для Контура и который будет зависеть от http_toolkit с github, и вроде зависимости не придётся менять)
path: dist/ | ||
- name: Publish distribution 📦 to PyPI | ||
uses: pypa/gh-action-pypi-publish@release/v1 | ||
github-release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
стоит ли оставлять такую job для создания релиза в github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Напомню, что в github можно создавать теги с помощью команды или создания релиза в web-интерфейсе. И во время второго случая эта job будет падать с ошибкой
README.md
Outdated
# kontur_http_toolkit_core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
перенёс сюда информацию с quickstart.md
# Conflicts: # README.md # docs/TRANSPORT.md # pyproject.toml # tox.ini
Публикация http-toolkit в open-source