Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] pypi release only on GH release #1656

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Sep 7, 2024

This PR ensures that the release workflow is triggered only on GitHub release.

Currently, it seems the release is triggered on every push to master - though it has thankfully failed for the past merges.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Sep 7, 2024
@fkiraly fkiraly merged commit fa3dc24 into master Sep 7, 2024
35 checks passed
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (e2bf3fd) to head (a3ba1dd).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1656   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          32       32           
  Lines        4780     4780           
=======================================
  Hits         4309     4309           
  Misses        471      471           
Flag Coverage Δ
cpu 90.14% <ø> (ø)
pytest 90.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants