-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Bayesian Linear Regression using Normal Conjugate Prior #500
Open
meraldoantonio
wants to merge
36
commits into
sktime:main
Choose a base branch
from
meraldoantonio:pymc_dev_conjugate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 29 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
9589ef8
Initialized bayesian conjugate class
2d58430
Added docstring example
08ae9d8
Added BayesianConjugateLinearRegressor
153f561
Changed parameterization
de68ef5
Removed dependency
fc3baac
added init
419f0c7
Changed test
82a8c75
Changed test
c3e6c56
Changed test
17d8e6a
Removed numpy array conversion in init
fc07dd9
Only allows initialization using Normal distribution from skpro
f35d064
Naming changes
87ca46a
Changed the shape of the test samples
ed5f81f
Changed the initiation process to numpy
ab59af2
Reworked logic
df7d0bb
Reworked recentering logic
cdb46b9
Make y_pred a series
4bae2f3
Only infer num_features during fit
d765033
Change col names
270be35
Change col names
fdd246f
Change col names
fb9f8db
Change col names
6439dc9
added second test param
9801221
changed update logic
8d2bb57
changed update logic
5e8c069
Remove centering
86b3aa0
Added example notebook
b20a255
Clarified that Normal doesn't result in multivariate normal
dc6cc54
removed kernelspec
f9a942f
reverted changes to 03_ example notebook
f32f887
formatting
4e998df
restructured example folder
d6342b9
Renamed notebook for consistency with the name of estimator
dddaa6c
Added line on BayesianMCMCLinearRegressor
9807a93
Renamed subfolder to abyesian
4ee08e6
Changed estimator name removed MCMC
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -195,3 +195,14 @@ Base classes | |
:template: class.rst | ||
|
||
BaseProbaRegressor | ||
|
||
Bayesian | ||
------------ | ||
|
||
.. currentmodule:: skpro.regression.bayesian.bayesian_conjugate | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the |
||
|
||
.. autosummary:: | ||
:toctree: auto_generated/ | ||
:template: class.rst | ||
|
||
BayesianConjugateLinearRegressor |
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
underline should be as long as the header. I would also put it in a single section with the other regressor.