Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document nginx ingress (skupper-440) #253

Merged
merged 2 commits into from
Oct 17, 2024
Merged

document nginx ingress (skupper-440) #253

merged 2 commits into from
Oct 17, 2024

Conversation

pwright
Copy link
Member

@pwright pwright commented Oct 16, 2024

No description provided.

@pwright pwright requested a review from grs October 16, 2024 13:52
grs
grs approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@grs grs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Might be worth stating that using the nginx ingress controller for skupper requires enabling ssl passthrough (a command line option which needs to be specified in the nginx ingress controller deployment)

@pwright pwright merged commit e10cdd4 into skupperproject:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grs grs grs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwright @grs