Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only manually set cookie for mobile app #253

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Only manually set cookie for mobile app #253

merged 1 commit into from
Aug 4, 2023

Conversation

skydread1
Copy link
Owner

Closes #252

  • only manually set cookies for the mobile app
  • introduce http-xhrio-default to refactor http-xhrio fx

flybot-nam-nguyenhoai
flybot-nam-nguyenhoai approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@flybot-nam-nguyenhoai flybot-nam-nguyenhoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, cookie warnings no longer appear, all tests passed. Ready to merge.

@skydread1 skydread1 merged commit 6fc9694 into master Aug 4, 2023
2 checks passed
@skydread1 skydread1 deleted the 252-unsafe-header-cookie-fix branch November 2, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flybot-nam-nguyenhoai flybot-nam-nguyenhoai flybot-nam-nguyenhoai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refused to set unsafe header cookie
2 participants
@skydread1 @flybot-nam-nguyenhoai