Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle post edits with no content changes #259

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Handle post edits with no content changes #259

merged 3 commits into from
Aug 4, 2023

Conversation

flybot-nam-nguyenhoai
Copy link
Contributor

@flybot-nam-nguyenhoai flybot-nam-nguyenhoai commented Aug 4, 2023 •
edited
Loading

Closes #256

New behavior

  • On the front end, when the user attempts to submit a post edit without changing any content first:

    • Send a warning notification.
    • Keep the post in edit mode.

  • On the back end, when receiving a post submission with the same content as the existing post

    • Include the existing post in the HTTP response.
    • Do not update the database (e.g., do not change the post's :post/last-edit-date).

Note

Post content consists of :post/page, :post/md-content, :post/css-class, :post/image-beside and :post/default-order.

skydread1
skydread1 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Owner

@skydread1 skydread1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@skydread1 skydread1 merged commit 5ac35f2 into skydread1:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydread1 skydread1 skydread1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post edits with no changes are still submitted
2 participants
@flybot-nam-nguyenhoai @skydread1