Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow owner to add back editor from UI #263

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Allow owner to add back editor from UI #263

merged 4 commits into from
Aug 4, 2023

Conversation

skydread1
Copy link
Owner

@skydread1 skydread1 commented Aug 4, 2023 •
edited
Loading

Closes #262

  • add the backend logic to add back the :editor role to an existing user
  • add the UI admin form to give back :editor role to an existing user

@skydread1 skydread1 self-assigned this Aug 4, 2023
flybot-nam-nguyenhoai
flybot-nam-nguyenhoai approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@flybot-nam-nguyenhoai flybot-nam-nguyenhoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, all tests passed. Ready to merge.

@skydread1 skydread1 merged commit d6792b5 into master Aug 4, 2023
2 checks passed
@skydread1 skydread1 deleted the 262-editor-role-is-missing branch November 2, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flybot-nam-nguyenhoai flybot-nam-nguyenhoai flybot-nam-nguyenhoai approved these changes

Assignees

@skydread1 skydread1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some logged-in users do not have the editor role
2 participants
@skydread1 @flybot-nam-nguyenhoai