Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): specify max pyee version #108

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

atkinsonm
Copy link
Contributor

Summary

Specify the maximum version of pyee allowed. This is to resolve the error ImportError: cannot import name 'BaseEventEmitter' from 'pyee' (/venv/lib/python3.8/site-packages/pyee/__init__.py) caused by the latest release of pyee.

Requirements (place an x in each [ ])

Copy link

salesforce-cla bot commented Sep 4, 2024

Thanks for the contribution! Before we can merge this, we need @atkinsonm to sign the Salesforce Inc. Contributor License Agreement.

@srajiang srajiang self-assigned this Sep 4, 2024
@srajiang srajiang self-requested a review September 4, 2024 19:13
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srajiang srajiang merged commit 13dead9 into slackapi:main Sep 4, 2024
8 checks passed
@srajiang srajiang removed their assignment Sep 4, 2024
@bsodenkamp-starz
Copy link

bsodenkamp-starz commented Sep 4, 2024

@srajiang will you release soon with this update? I think 3.0.2 is broken by this.
@seratch

@seratch seratch added this to the 3.0.3 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants