Add support for internal visibility modifier #67
+191,881
−198,166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Modern Hacklang introduced modules and the internal visibility modifier to mark methods and functions as only accessible from within the current module. The Hacklang treesitter grammar doesn't support the internal visibility modifier yet. This diff addresses it. Test Plan: Grammar tests pass: ``` tree-sitter generate tree-sitter test ``` Reviewers: Subscribers: Tasks: Tags:
andryak
force-pushed
the
internal_visibility_modifier
branch
from
c7a78c7
to
0ee82f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modern Hacklang introduced modules and the internal visibility modifier to mark methods and functions as only accessible from within the current module.
The Hacklang treesitter grammar doesn't support the internal visibility modifier yet. This diff addresses it.
Grammar tests pass:
Requirements (place an
xin each[ ])npm run test-corpusto make sure all tests pass.