Fix flake8 warnings #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 20, 2023 23:19
…k before binary operator
…fix_flake8_warnings
lisazacarias
requested changes
Oct 23, 2023
lisazacarias
approved these changes
Oct 23, 2023
nneveu
approved these changes
Oct 23, 2023
| @@ -0,0 +1,36 @@ | |||
| #!/usr/local/lcls/package/python/current/bin/python | |||
|
🥳 🍾 🎆 |
Derikka
pushed a commit
to Derikka/lcls-tools
that referenced
this pull request
Mar 17, 2024
* ignore too many hashes for block-comment, and contraversial line break before binary operator * flake8 fixes * remove lambda for flake8 * changing unittest command, change from python-app to python-package workflow. * add requirements for workflow install step * make callback a callable for test to pass * add exception for line-length * remove unnecessary file --------- Co-authored-by: matt <matt@SLACMachine.myguest.virtualbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Most of the changes include reformatting or removing unused variable/imports.
I have added a
.flake8file that allows the errors/warnings to be configured. For example, there is an allowable line-length that is configured in that file to be 120 (PyCharm default), as well as ignoring some other warnings.To Check
96_fix_flake8_warnings) in your local repositorypython3 -m pip install flake8) if you do not already have itflake8 .in the lcls-tools repositoryOther notes
The first stage of the pipeline should pass after these changes have been merged and we can move onto fixing the unit-tests.
closes #96