Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve AnnotationInstance.hashCode() #329

Merged
merged 1 commit into from
Sep 22, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions core/src/main/java/org/jboss/jandex/AnnotationInstance.java
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,7 @@ public String toString() {
/**
* Returns whether this annotation instance is equal to another instance.
* Two annotation instances are equal if their names and values of their members are equal,
* and they share the exact same {@code AnnotationTarget} instance. The latter restriction
* may be softened in future versions.
* and they share the exact same {@code AnnotationTarget} instance.
*
* @param o the annotation instance to compare to
* @return {@code true} if equal, {@code false} if not
Expand Down Expand Up @@ -463,6 +462,36 @@ public int hashCode() {
int result = name.hashCode();
result = 31 * result + Arrays.hashCode(values);

if (target != null) {
switch (target.kind()) {
case CLASS:
result = 31 * result + target.asClass().name().hashCode();
break;
case METHOD:
result = 31 * result + target.asMethod().declaringClass().name().hashCode();
result = 31 * result + target.asMethod().name().hashCode();
break;
case FIELD:
result = 31 * result + target.asField().declaringClass().name().hashCode();
result = 31 * result + target.asField().name().hashCode();
break;
case METHOD_PARAMETER:
result = 31 * result + target.asMethodParameter().method().declaringClass().name().hashCode();
result = 31 * result + target.asMethodParameter().method().name().hashCode();
result = 31 * result + target.asMethodParameter().position();
break;
case RECORD_COMPONENT:
result = 31 * result + target.asRecordComponent().declaringClass().name().hashCode();
result = 31 * result + target.asRecordComponent().name().hashCode();
break;
case TYPE:
if (target.asType().target() != null) {
result = 31 * result + target.asType().target().name().hashCode();
}
break;
}
}

return result;
}

Expand Down
Loading