Skip to content

Commit

Permalink
Fix release build
Browse files Browse the repository at this point in the history
* Fully modularize modules which did not previously have `module-info.yml`
* Disable JavaDoc legacy mode
  • Loading branch information
dmlloyd committed Nov 19, 2024
1 parent 1174e0e commit 97702ec
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 53 deletions.
9 changes: 0 additions & 9 deletions classloader/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,6 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>io.github.dmlloyd.module-info</groupId>
<artifactId>module-info</artifactId>
</plugin>
</plugins>
</build>

<profiles>
<profile>
<id>coverage</id>
Expand Down
2 changes: 2 additions & 0 deletions classloader/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
module io.smallrye.common.classloader {
}
9 changes: 0 additions & 9 deletions io/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,6 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>io.github.dmlloyd.module-info</groupId>
<artifactId>module-info</artifactId>
</plugin>
</plugins>
</build>

<profiles>
<profile>
<id>coverage</id>
Expand Down
2 changes: 2 additions & 0 deletions io/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
module io.smallrye.common.io {
}
9 changes: 0 additions & 9 deletions os/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,6 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>io.github.dmlloyd.module-info</groupId>
<artifactId>module-info</artifactId>
</plugin>
</plugins>
</build>

<profiles>
<profile>
<id>coverage</id>
Expand Down
2 changes: 2 additions & 0 deletions os/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
module io.smallrye.common.os {
}
26 changes: 0 additions & 26 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
<properties>
<!-- Plugins -->
<version.bridger>1.6.Final</version.bridger>
<version.module-info>2.1</version.module-info>
<version.sundrio>0.200.0</version.sundrio>
<version.jandex-maven-plugin>1.2.3</version.jandex-maven-plugin>

Expand Down Expand Up @@ -153,31 +152,6 @@
</execution>
</executions>
</plugin>
<!-- TODO - Workaround for javadoc / module-info generation -->
<!-- The javadoc plugin expects a module-info.java (because it finds the .class generated one), and
because we don't have one, it fails. Forcing to legacy mode removes any module configuration for the
javadoc command
-->
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<legacyMode>true</legacyMode>
</configuration>
</plugin>
<plugin>
<groupId>io.github.dmlloyd.module-info</groupId>
<artifactId>module-info</artifactId>
<version>${version.module-info}</version>
<executions>
<execution>
<id>module-info</id>
<phase>process-classes</phase>
<goals>
<goal>generate</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.jboss.bridger</groupId>
<artifactId>bridger</artifactId>
Expand Down

0 comments on commit 97702ec

Please sign in to comment.