Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection for WSL #312

Merged
merged 1 commit into from
May 17, 2024
Merged

Add detection for WSL #312

merged 1 commit into from
May 17, 2024

Conversation

dmlloyd
Copy link
Collaborator

@dmlloyd dmlloyd commented May 10, 2024

Fixes #311

@dmlloyd dmlloyd merged commit 8aa3ca1 into smallrye:main May 17, 2024
4 checks passed
@dmlloyd dmlloyd deleted the wsl branch May 17, 2024 16:42
@github-actions github-actions bot added this to the 2.5.0 milestone May 17, 2024
@gsmet
Copy link

gsmet commented May 17, 2024

Maybe it's a stupid question but are we sure Microsoft is not shipping a distribution specific to Azure that might contain microsoft in /proc/version?

@dmlloyd
Copy link
Collaborator Author

dmlloyd commented May 17, 2024

Based on my research, I don't think so; this seems to be the most common idiom for detection of WSL and nobody has mentioned it not working on Azure. That said, there's nothing quite like testing :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for detecting WSL
2 participants