Switch to GitHub actions and cleanup syntax/API use #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update a jinja2 import to avoid removed methods (removal in 3.1, new method appeared in 3.0 - so bump requirement to 3.0 too) - Fix a few python syntax warnings. - Update README's mention of what this repo can parse. - Fix a Practitioner typo in a comment. Fix by Kevin Wood (kwood16).
mikix
force-pushed
the
mikix/modernization
branch
from
92b2544 to
702b066
Compare
mikix
commented
Jul 12, 2024
README.md
Outdated
| The `master` branch is currently capable of parsing _STU 3, v3.0.0_. | ||
| The `develop` branch should be capable of parsing the continuous integration build and will be merged into master on new major FHIR releases. | ||
| There may be tags for specific freezes, see [releases](https://github.com/smart-on-fhir/fhir-parser/releases). | ||
| The `master` branch is currently capable of parsing _R5_. |
There was a problem hiding this comment.
The develop branch is strictly 14 commits behind master currently - folks seem to have switched to trunk-based dev (which seems fine, since it's currently backwards compatible).
I took out the link to releases because (a) there are no release, just tags and (b) even the tags aren't very up to date - just a bunch of 1.x stuff from early days.
mikix
changed the title
mikix
commented
Jul 12, 2024
Comment on lines
-1
to
-4
| Jinja2>=2.9.5 | ||
| MarkupSafe==0.23 | ||
| colorlog>=2.10.0 | ||
| jinja2>=3.0 | ||
| requests>=2.13.0 | ||
| colorlog==2.10.0 |
There was a problem hiding this comment.
MarkupSafe didn't seem to be used anymore, so I removed it (and loosened the pins on the other requirements)
mikix
force-pushed
the
mikix/modernization
branch
from
0a41fb2 to
3fb65f7
Compare
This was referenced Jul 12, 2024
dogversioning
approved these changes
Jul 12, 2024
mikix
force-pushed
the
mikix/modernization
branch
from
3fb65f7 to
94adfa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
Fixes #47