Feature/add error logging for graphql execution errors #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2019 15:50
…d development * In production we are using graylog so the rails logs should be formatted as gelf messages
…n Error * If a graphql query execution fails the rails server doesn't know about it and doesn't log it * add method to log output of the graphql server if it returns a result hash with an "errors" key
|
Code Climate has analyzed commit 80de592 and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
donni106
reviewed
Aug 12, 2019
| @@ -83,7 +83,7 @@ | |||
|
|
|||
| # Use a different logger for distributed setups. | |||
| # require 'syslog/logger' | |||
| # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new 'app-name') | |||
| config.logger = GELF::Logger.new("localhost", 12219, "WAN", { :facility => "YOUR_APP_NAME" }) | |||
There was a problem hiding this comment.
Here is missing the exchange of "YOUR_APP_NAME". Isn't there a environment variable with the app name, so that can be used here instead of a plain string?
donni106
deleted the
feature/add-error-logging-for-graphql-execution-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vorschlag zur Lösung von #67
Add GELF with Lograge as new standard logging method in production and development
Add Message to the Error Log if the GraphQL Server throws an Execution Error
#67