Creating set of test selectors using non-existing chain ids #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selectors.go
Outdated
| for k, v := range selectors { | ||
| output[k] = v | ||
| } | ||
| for k, v := range testSelectors { |
There was a problem hiding this comment.
I think we'd want to ensure these are distinct sets right? ie panic on set overlap
There was a problem hiding this comment.
Makes sense, will do this defensive check.
There was a problem hiding this comment.
It's always read from the yml file. So maybe instead of panic, we could just have a test that will verify if there is no overlap between these two?
mateusz-sekara
force-pushed
the
test-selectors
branch
from
111d4d5
to
3efb578
Compare
mateusz-sekara
force-pushed
the
test-selectors
branch
from
3efb578
to
d7e7c50
Compare
connorwstein
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.