Ccip-4681 lint fix for deployment/ccip #15783
Conversation
AnieeG
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
b-gopalswami
|
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , GolangCI Lint (integration-tests) , Core Tests (go_core_tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests_integration) , test-scripts , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/changeset, ubuntu-latest) , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/changeset/v1_5, ubuntu-latest) , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/view/v1_2, ubuntu-latest) , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/view/v1_5, ubuntu-latest) , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/view/v1_6, ubuntu-latest) , lint , SonarQube Scan , Flakey Test Detection , Flakeguard Deployment Project / Report 1. Timeout error during log pruning:[Run tests]Source of Error:logger.go:146: 2024-12-19T21:35:25.143Z ERROR EVM.90000001.LogPoller logpoller/log_poller.go:1178 Unable to find excess logs for pruning {"version": "unset@unset", "err": "timeout: context canceled"}
logger.go:146: 2024-12-19T21:35:25.143Z ERROR EVM.90000001.LogPoller logpoller/log_poller.go:714 unable to prune expired logs {"version": "unset@unset", "err": "timeout: context canceled"}Suggested fix: Increase the timeout duration for the log pruning operation to ensure it has sufficient time to complete. Alternatively, optimize the log pruning process to execute more quickly. 2. Test failure in
|
| go func() { | ||
| require.NoError(t, wg.Wait()) | ||
| close(done) | ||
| errFound <- wg.Wait() |
There was a problem hiding this comment.
close(errFound) is still valid here
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (tc *TestConfigs) MustSetEnvTypeOrDefault(t *testing.T) { | ||
| envType := os.Getenv(ENVTESTTYPE) | ||
| if envType == "" || envType == string(Memory) { | ||
| switch envType { | ||
| case string(Memory): |
There was a problem hiding this comment.
You lost the default handling:
| case string(Memory): | |
| case "", string(Memory): |
| @@ -2,6 +2,7 @@ package changeset | |||
|
|
|||
| import ( | |||
| "context" | |||
| "errors" | |||
There was a problem hiding this comment.
Looks like pkg/errors also has a New function, so no need to import both of these.
| @@ -89,3 +89,10 @@ func (params OCRParameters) Validate() error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func MustGetInt(num uint64) int { | |||
| if num > uint64(int(^uint(0)>>1)) { | |||
There was a problem hiding this comment.
| if num > uint64(int(^uint(0)>>1)) { | |
| if num > math.MaxInt { |
Requires
Supports