Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quieten enhanced telem #15793

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Quieten enhanced telem #15793

wants to merge 1 commit into from

Conversation

samsondav
Copy link
Collaborator

@samsondav samsondav commented Dec 20, 2024 •
edited
Loading

Enhanced telemetry logging is way too verbose since individual EA failures are quite normal and commonplace, and in any case, logged elsewhere.

@samsondav samsondav marked this pull request as ready for review December 20, 2024 18:00
@samsondav samsondav requested review from a team as code owners December 20, 2024 18:00
@samsondav samsondav requested a review from ilija42 December 20, 2024 18:00
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@samsondav samsondav force-pushed the quieten_enhanced_ea_telemetry branch from 289bf88 to c351767 Compare December 20, 2024 18:05
ilija42
ilija42 previously approved these changes Dec 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@samsondav samsondav force-pushed the quieten_enhanced_ea_telemetry branch from c351767 to 5e3db84 Compare December 20, 2024 18:30
jmank88
jmank88 previously approved these changes Dec 20, 2024
View reviewed changes
@samsondav samsondav force-pushed the quieten_enhanced_ea_telemetry branch from 5e3db84 to 1f59467 Compare December 20, 2024 18:35
@samsondav samsondav force-pushed the quieten_enhanced_ea_telemetry branch from 1f59467 to 631f1c6 Compare December 20, 2024 18:45
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@denis-chernov-smartcontract denis-chernov-smartcontract Awaiting requested review from denis-chernov-smartcontract

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samsondav @jmank88 @ilija42 @denis-chernov-smartcontract