Merge pull request #9 from smartdevicelink/fix/bson_iterator_segfault

Fixes segfault in `bson_object_iterator_next`
smartdevicelink · Oct 30, 2017 · 854740d · 854740d
2 parents a3a1dc6 + dee59a3
commit 854740d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/bson_object.c b/src/bson_object.c
@@ -398,7 +398,13 @@ MapIterator bson_object_iterator(BsonObject *obj) {
 BsonObjectEntry bson_object_iterator_next(MapIterator *iterator) {
   MapEntry *entry = emhashmap_iterator_next(iterator);
   BsonObjectEntry bsonEntry;
-  strncpy(bsonEntry.key, entry->key, 255);
-  bsonEntry.element = (BsonElement *)entry->value;
+  if(entry == NULL) {
+    bsonEntry.key[0] = 0x00; //Assign empty string
+    bsonEntry.element = NULL;
+  }
+  else {
+    strncpy(bsonEntry.key, entry->key, 255);
+    bsonEntry.element = (BsonElement *)entry->value;
+  }
   return bsonEntry;
 }
diff --git a/src/bson_object.h b/src/bson_object.h
@@ -279,7 +279,8 @@ MapIterator bson_object_iterator(BsonObject *obj);
   @param iterator - The iterator to be advanced
 
   @return - The next BSON object entry in the object if it exists, 
-            NULL if the iterator has moved past the end of the entry list
+            an entry with a NULL element if the iterator has moved past the end 
+            of the entry list
 */
 BsonObjectEntry bson_object_iterator_next(MapIterator *iterator);