Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename-contigs to include target bed intersection and add mapping files to resources #73

Merged
merged 21 commits into from
Apr 22, 2024

Conversation

famosab
Copy link
Collaborator

@famosab famosab commented Apr 16, 2024

  • Avoiding errors with contigs not being present in the target file.
  • Adding more elaborate rename files as resources.

@famosab
Copy link
Collaborator Author

famosab commented Apr 16, 2024

I am intersecting with the confidence regions and run into

[E::faidx_adjust_position] The sequence "chrEBV" was not found
faidx_fetch_seq failed at chrEBV:68570
Error: line number 30405 of file /dev/fd/63 has 7 fields, but 11 were expected.

Edit: Same error for target regions. But using test regions does not work directly because they are stratified by coverage?

Edit 2: Removing EBV and decoy manually leads to everything working again -> but we want to avoid doing that, something about the way I do it seems wrong to me.

@famosab
Copy link
Collaborator Author

famosab commented Apr 17, 2024

I tried. out confidence and target regions locally and I am not sure which one should be used. I changed the norm to pipe the result of the intersect into bcftools norm otherwise I always ran into the above error.

workflow/rules/common.smk Outdated Show resolved Hide resolved
workflow/rules/eval.smk Outdated Show resolved Hide resolved
@famosab famosab changed the title fix: rename-contigs to include target bed intersection fix: rename-contigs to include target bed intersection and add mapping files to resources Apr 18, 2024
@famosab
Copy link
Collaborator Author

famosab commented Apr 18, 2024

Also works with the Freiburg data (the VCFs containing chrEBV and _decoy).

workflow/rules/common.smk Outdated Show resolved Hide resolved
workflow/rules/common.smk Outdated Show resolved Hide resolved
workflow/rules/common.smk Outdated Show resolved Hide resolved
@johanneskoester johanneskoester merged commit 65930c5 into main Apr 22, 2024
5 checks passed
@johanneskoester johanneskoester deleted the fix/rename-contigs branch April 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants