doc(ark-springboot-starter): 补充注释说明 WebServerFactory 第二个IF空值判断的必要性

sofastack · Aug 19, 2024 · 66601fc · 66601fc
1 parent 698d42f
commit 66601fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/...er/src/main/java/com/alipay/sofa/ark/springboot/web/ArkNettyReactiveWebServerFactory.java b/...er/src/main/java/com/alipay/sofa/ark/springboot/web/ArkNettyReactiveWebServerFactory.java
@@ -81,6 +81,8 @@ public WebServer getWebServer(HttpHandler httpHandler) {
             ArkClient.getInjectionService().inject(this);
         }
         if (embeddedNettyService == null) {
+            // 原有的逻辑中也有这个空值判断, 不确定注入后是否还会有用例会导致 embeddedNettyService 为空
+            // 因此仍保留此 if 空值判断
             return super.getWebServer(httpHandler);
         }
         if (embeddedNettyService.getEmbedServer(getPort()) == null) {

diff --git a/...er/src/main/java/com/alipay/sofa/ark/springboot/web/ArkTomcatServletWebServerFactory.java b/...er/src/main/java/com/alipay/sofa/ark/springboot/web/ArkTomcatServletWebServerFactory.java
@@ -93,6 +93,8 @@ public WebServer getWebServer(ServletContextInitializer... initializers) {
             ArkClient.getInjectionService().inject(this);
         }
         if (embeddedServerService == null) {
+            // 原有的逻辑中也有这个空值判断, 不确定注入后是否还会有用例会导致 embeddedServerService 为空
+            // 因此仍保留此 if 空值判断
             return super.getWebServer(initializers);
         }
         if (embeddedServerService.getEmbedServer(getPort()) == null) {