fix: issue with isModelGenerating when switching between multiple models #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmjkb
requested changes
Dec 19, 2024
| if (llamaModule != null || isFetching) { | ||
| promise.reject("Model already loaded", "Model is already loaded or fetching") | ||
| if (isFetching) { | ||
| promise.reject("Model already loaded", "Model is already fetching") |
There was a problem hiding this comment.
The first argument seems wrong
ios/RnExecutorch/LLM.mm
Outdated
| if(self->runner || isFetching){ | ||
|
|
||
| if(isFetching){ | ||
| reject(@"model_already_loaded", @"Model and tokenizer already loaded", nil); |
There was a problem hiding this comment.
Is this error message correct? you're not checking if its loaded
| @@ -148,10 +149,6 @@ class LLM(reactContext: ReactApplicationContext) : | |||
| llamaModule!!.stop() | |||
| } | |||
|
|
|||
| override fun deleteModule() { | |||
There was a problem hiding this comment.
Why are we getting rid of this?
There was a problem hiding this comment.
I noticed that it doesn't really change memory usage, but let's leave it for now as it's not breaking anything
chmjkb
approved these changes
Dec 20, 2024
NorbertKlockiewicz
deleted the
@norbertklockiewicz/fix-isGenerating-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a problem when user was switching between multiple llms in one component, to fix this issue I removed code related to handling strict mode problems(strict mode was causing problems with event listeners also so I think we should ignore it as it isn't the best with background tasks), I've also remove deleteModule native function as it wasn't really doing anything, now user can download multiple llms within one component and seamlessly switch between them without bugs.
The problem was mentioned in issue #42
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes