-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Information about version compatibility and a note about expo in metro config docs #6743
base: main
Are you sure you want to change the base?
Conversation
const config = { | ||
// Your existing Metro configuration options | ||
}; | ||
|
||
module.exports = wrapWithReanimatedMetroConfig(config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also was confusing for some people who copied code from this example with the empty config
and wondered why RN app doesn't start. I don't know how to best represent this in code, so I just removed config
so that people can think for a while what this config should be before starting the app.
I think that the best way to represent this would be to show something similar to git diff but I don't know if we have this functionality already added in docs.
We're not using expo/metro-config, but Any insights what to do here? Should we wrap? Is the order important? Right now, we export like so: module.exports = wrapWithReanimatedMetroConfig(
withNativeWind(config, {
input: './global.css',
inlineRem: 14,
})
) While config is const config = getSentryExpoConfig(projectRoot) I don't see any issues, but want to double check. |
I checked how What On the contrary, the default React Native metro config excludes only some paths from Summing up, if you already use tl;dr You can safely remove |
Thank you so much for the clarification. I'll test and report back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please DRY these changes as we discussed offline.
Summary
This PR adds version compatibility information to metro config docs. This change is motivated by the fact that I received a few messages from people who got stuck on this configuration step and wondered why it doesn't work.
I also noticed that this wrapper doesn't change anything if someone uses
expo/metro-config
instead of the default React Native@react-native/metro-config
config (e.g. someone creates an Expo-managed project instead of a bare workflow). I added information about this to notes.Example images
Getting Started
Accurate Call Stacks
Added the Important note box and the Version Compatibility section
Added these 2 remarks: