Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto cache path fetching using scarb cache path #13

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

ametel01
Copy link
Contributor

solves #11

@ametel01 ametel01 requested a review from mkaput as a code owner August 13, 2023 05:48
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll unfortunately have to merge this later, when Scarb containing this command will be released and widely used. I expect this to happen around Starknet 0.13

lib/cache-utils.js Show resolved Hide resolved
@ametel01 ametel01 force-pushed the refacto-cache-path-fetching branch 2 times, most recently from 05f78b8 to 2ba10e7 Compare August 16, 2023 14:12
lib/cache-utils.js Show resolved Hide resolved
added await to function calls


npm run build


added missing await
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️❤️❤️❤️❤️

@mkaput
Copy link
Member

mkaput commented Aug 24, 2023

OK, I gave this a thought and I think we have to preserve the old behaviour indefinitely, if we want to stick with v1 version line for this action. I'll merge this PR now, and I'll add falling back logic in separate PR.

@mkaput mkaput added this pull request to the merge queue Aug 24, 2023
Merged via the queue into software-mansion:main with commit 10076ca Aug 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants