refacto cache path fetching using scarb cache path #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
approved these changes
Aug 16, 2023
mkaput
requested changes
Aug 16, 2023
ametel01
force-pushed
the
refacto-cache-path-fetching
branch
2 times, most recently
from
05f78b8
to
2ba10e7
Compare
mkaput
requested changes
Aug 17, 2023
added await to function calls npm run build added missing await
ametel01
force-pushed
the
refacto-cache-path-fetching
branch
from
2ba10e7
to
c2d7d28
Compare
|
OK, I gave this a thought and I think we have to preserve the old behaviour indefinitely, if we want to stick with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #11