-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Scarb version from .tool-versions
file
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciektr
reviewed
Jul 27, 2023
szymmis
force-pushed
the
read-tool-versions
branch
from
July 27, 2023 11:57
255b2d7
to
153d98e
Compare
maciektr
reviewed
Jul 27, 2023
mkaput
requested changes
Jul 27, 2023
szymmis
force-pushed
the
read-tool-versions
branch
2 times, most recently
from
July 27, 2023 13:09
5739c26
to
fb18745
Compare
szymmis
force-pushed
the
read-tool-versions
branch
from
July 27, 2023 13:12
fb18745
to
d9624a3
Compare
mkaput
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please add a test and LGTM 🎉
szymmis
force-pushed
the
read-tool-versions
branch
from
July 27, 2023 14:00
f52068f
to
5252e52
Compare
mkaput
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please rebase commits so that they’ll have a linear meaning and I’m happy to accept this :)
szymmis
force-pushed
the
read-tool-versions
branch
from
July 27, 2023 15:17
44eddc9
to
32f1f42
Compare
szymmis
force-pushed
the
read-tool-versions
branch
from
July 27, 2023 16:12
32f1f42
to
d748861
Compare
mkaput
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1.
The action will now be capable of reading Scarb version from
.tool-versions
when it is not specified in the workflow file asscarb-version
parameter is no longer required.Steps of determining Scarb version in order of importance:
scarb-version
parameter in action yml file.tool-version
fileWhen
scarb-version
is not specified, action will look for.tool-version
file in the root directory of the repository and if it fails to find the file or the scarb entry it will fallback to the latest version of Scarb.