Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to devnet-rs and sncast #98

Merged
merged 74 commits into from
Sep 28, 2023
Merged

Migrate to devnet-rs and sncast #98

merged 74 commits into from
Sep 28, 2023

Conversation

DelevoXDG
Copy link
Collaborator

@DelevoXDG DelevoXDG commented Sep 14, 2023 •
edited
Loading

Describe your changes

  • Update DevnetClient
    • Migrate to devnet-rs from pythonic devnet
    • Migrate to sncast from starknet cli
  • Use Cairo 1 contracts for testing instead of Cairo 0 (sncast does not support Cairo 0)
  • Update CI
  • Remove pythonic deps
  • Update README.md
  • Remove compiling contracts
  • Refactor DevnetClient

Linked issues

Closes #90
Closes #83

Breaking changes

  • This issue contains breaking changes

dioKaratzas and others added 27 commits July 18, 2023 15:20
@dioKaratzas
[CHANGE] starknet_estimateMessageFee method to support v0.4.x schema #85
b8695b5
@DelevoXDG
Add compileContracts instruction to readme
6d09ebd
@DelevoXDG
Update message dataclasses (0.4.0-rc2)
7011dec
@DelevoXDG
Add revert reason, finality and execution status
33915bc
@DelevoXDG
Add sign that relies on tx_hash instead of tx
00991a4
@DelevoXDG
Make hash optional, decode optional fields only if present
fc047af
@DelevoXDG
Remove cairo 0 contracts; Add cairo 1 contracts; add Scarb.toml
f252b7f
@DelevoXDG
Merge main
1828c23
@DelevoXDG
Add old tx status
b67da3a
@DelevoXDG
Add SnCast models; Add SnCastResponseWrapper
2e30f8c
@DelevoXDG
[WIP] Update DevnetClient to use devnet-rs and sncast
e72f273
@DelevoXDG
Update tests to support new Devnet Client
52287b5
@DelevoXDG
Format
189063d
@DelevoXDG
Merge branch 'main' into feat/migrate-devnet-rs
7c79eae
@DelevoXDG
Remove pythonic deps
a3383f8
@DelevoXDG
Fix typo in variables
bb1c30d
@DelevoXDG
Install scarb, sncast, devnet-rs on CI
e6301a7
@DelevoXDG
Add missing pushd in "build devnet" step
adf33fb
@DelevoXDG
Add DEVNET_BUILD_PATH env var to CI
d75352d
@DelevoXDG
Remove deployDefaultAccount
8daa3f8
@DelevoXDG
Remove old devnet functions
046f97d
@DelevoXDG
Fix pushd path
cb1ae5a
@DelevoXDG
Fix pushd (again)
95cb827
@DelevoXDG
Specify versions in build steps
4b3f24d
@DelevoXDG
Disable running tests so cache gets saved
32cffda
@DelevoXDG
Misc refactor DevnetClient
6126e16
@DelevoXDG
Format
cb83abb
@DelevoXDG DelevoXDG self-assigned this Sep 14, 2023
@DelevoXDG DelevoXDG changed the title [WIP] Migrate to devnet-rs and sncast Migrate to devnet-rs and sncast Sep 15, 2023
@DelevoXDG
Copy link
Collaborator Author

DelevoXDG commented Sep 15, 2023 •
edited
Loading

I'm not sure whether cast-based functions should do so much of mimicking cast functionality with those arguments, but also I don't think it necessarily hurts.
If you think DevnetClient can (and should be) simplified, I'm eager to hear any suggestions.

THenry14
THenry14 reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 🔥

.github/workflows/checks.yml Outdated Show resolved Hide resolved
bartekryba
bartekryba approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@bartekryba bartekryba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Great job on improving the codebase

@DelevoXDG DelevoXDG merged commit fbfd4bd into main Sep 28, 2023
1 check passed
@DelevoXDG DelevoXDG deleted the feat/migrate-devnet-rs branch September 28, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THenry14 THenry14 THenry14 left review comments

@bartekryba bartekryba bartekryba approved these changes

@tomek0123456789 tomek0123456789 Awaiting requested review from tomek0123456789

Assignees

@DelevoXDG DelevoXDG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to devnet-rs and sncast Add Cairo1 Support for Tests
4 participants
@DelevoXDG @THenry14 @bartekryba @dioKaratzas