Support windows mingw #1657
Merged
Support windows mingw #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你好。非常感谢帮我们优化代码。我看除了mingw的编译，还解决了我们很多windows下的细节和用法问题。 对了，如果你对windows编程熟悉，欢迎一起来搞一下全功能的多平台版，你可以开个独立项目来做，做好了我们把有需求的用户引导过去。Windows因为我们这边没有开发团队了，目前的更新状况确实的很对不起windows用户。 |
Barenboim
reviewed
Nov 20, 2024
src/kernel_win/WinPoller.cc
Outdated
| @@ -441,7 +441,7 @@ static void __accept_on_success(struct poller_result *res) | |||
| static void __connect_on_success(struct poller_result *res) | |||
| { | |||
| SOCKET sockfd = (SOCKET)res->data.handle; | |||
| ConnectContext *ctx = (ConnectContext *)res->data.context; | |||
| //ConnectContext *ctx = (ConnectContext *)res->data.context; | |||
There was a problem hiding this comment.
这些代码变化，直接把原来的那行删了就行，不用注释掉了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.