Add support of 'with' statement to ConfigDBConnector #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuh-80
changed the title
liuh-80
force-pushed
the
dev/liuh/support_with_statement
branch
from
117fbdd to
b998b56
Compare
qiluo-msft
reviewed
Dec 5, 2023
qiluo-msft
reviewed
Jan 9, 2024
| @@ -32,6 +32,11 @@ void DBInterface::close(const std::string& dbName) | |||
| m_redisClient.erase(dbName); | |||
There was a problem hiding this comment.
The 'with' state will not call this method, it will call the map::clear(), and because m_redisClient not store pointer or reference, the dtor of RedisContext will be invoke by clear() and release redis connection:
RedisContext::~RedisContext()
{
if(m_conn)
redisFree(m_conn);
}
There was a problem hiding this comment.
Agree. The original comment is invalid.
qiluo-msft
reviewed
Jan 9, 2024
common/dbinterface.cpp
Outdated
| @@ -32,6 +32,11 @@ void DBInterface::close(const std::string& dbName) | |||
| m_redisClient.erase(dbName); | |||
| } | |||
|
|
|||
| void DBInterface::close_all() | |||
qiluo-msft
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add support of 'with' statement to ConfigDBConnector
How I did it
Add enter and exit method to ConfigDBConnector
Work item tracking
How to verify it
Pass all UT and E2E test cases.
Add new UT to check ConfigDBConnector support 'with' statement
Which release branch to backport (provide reason below if selected)
Description for the changelog
Add support of 'with' statement to ConfigDBConnector
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)