Support ASIC/SDK health event #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
0023fc0 to
d17d3ad
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
d17d3ad to
17e625d
Compare
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
17e625d to
47bdabd
Compare
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
47bdabd to
16ff64d
Compare
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
16ff64d to
8f86a3e
Compare
|
Hi @prsunny |
prsunny
approved these changes
Mar 27, 2024
prsunny
reviewed
Mar 27, 2024
| @@ -521,6 +523,8 @@ namespace swss { | |||
|
|
|||
| #define STATE_TRANSCEIVER_INFO_TABLE_NAME "TRANSCEIVER_INFO" | |||
|
|
|||
| #define ASIC_SDK_HEALTH_EVENT_TABLE_NAME "ASIC_SDK_HEALTH_EVENT_TABLE" | |||
There was a problem hiding this comment.
missed this while reviewing, could you please prefix this with STATE_ ? (please raise a separate PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New table definition for ASIC/SDK health event