Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous type-checking updates #2614

Merged
merged 3 commits into from
Aug 31, 2024
Merged

Miscellaneous type-checking updates #2614

merged 3 commits into from
Aug 31, 2024

Commits on Aug 13, 2024

  1. dev-requirements: types-pkg-resources is deprecated 

    `pkg_resources` itself is typed in setuptools>=71.1, negating the need
to install type stubs.
    @dgw
    dgw committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c04ac82 View commit details
    Browse the repository at this point in the history

  2. tools.memories: SopelIdentifierMemory.update() override is intentional 

    mypy has to be told this explicitly, which means a new "runtime"
dependency/import that only has to do with type-checking... because
decorator evaluation can't be deferred like annotations can.

Sigh.
    @dgw
    dgw committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    04fca7a View commit details
    Browse the repository at this point in the history

  3. tools: fix union-attr type-check errors in OutputRedirect class 

    I'm very glad this is deprecated. The only reason I'm bothering to fix
this is because we can't remove it from the 8.0.x maintenance branch.
    @dgw
    dgw committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c8802f7 View commit details
    Browse the repository at this point in the history