Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: treat warning as info #51

Merged
merged 1 commit into from
Feb 13, 2024
Merged

chore: treat warning as info #51

merged 1 commit into from
Feb 13, 2024

Conversation

iBotPeaches
Copy link
Member

No description provided.

jyann
jyann approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@jyann jyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why the change? Warning seems appropriate in a catch block

@iBotPeaches
Copy link
Member Author

Out of curiosity, why the change? Warning seems appropriate in a catch block

Since we moved to reading the existing socket - this is misleading and not much a warning to emit into logs. System works as you expect.

@iBotPeaches iBotPeaches merged commit 8681df1 into master Feb 13, 2024
1 check passed
@iBotPeaches iBotPeaches deleted the debug-pid-message branch February 13, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bankamah Bankamah Bankamah approved these changes

@Vacoris Vacoris Vacoris approved these changes

@jyann jyann jyann approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iBotPeaches @jyann @Vacoris @Bankamah