Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_installation_package: support for ubuntu 24.04 #1274

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

san983
Copy link
Contributor

@san983 san983 commented Jun 11, 2024

Description

  • Adds support for Ubuntu 24.04 (nobel) for module docker_installation_package
  • Also adds 22.04 to CI

This is similar to the PR #1225

Issues Resolved

n/a

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@san983 san983 requested a review from a team as a code owner June 11, 2024 04:32
Stromweld
Stromweld previously approved these changes Jun 11, 2024
@san983
Copy link
Contributor Author

san983 commented Jun 11, 2024

Thanks @Stromweld, let me know if there is anything else needed to push this forward :)

@bmhughes
Copy link
Contributor

bmhughes commented Jul 8, 2024

Thanks @Stromweld, let me know if there is anything else needed to push this forward :)

Hi @san983,

Thanks for this, could you rebase on main and add a changelog entry and I'll look at getting this merged.

Thanks!

@bmhughes bmhughes added Feature Request Enhancement to existing functionality or new functionality Release: Minor Release to Chef Supermarket as a minor release when merged labels Jul 8, 2024
@san983
Copy link
Contributor Author

san983 commented Jul 12, 2024

Thanks @Stromweld, let me know if there is anything else needed to push this forward :)

Hi @san983,

Thanks for this, could you rebase on main and add a changelog entry and I'll look at getting this merged.

Thanks!

Done!

@Stromweld Stromweld merged commit be8e682 into sous-chefs:main Jul 15, 2024
36 of 53 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 11.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants