Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU support #1289

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Add GPU support #1289

merged 7 commits into from
Dec 11, 2024

Conversation

damacus
Copy link
Member

@damacus damacus commented Dec 10, 2024

Signed-off-by: Dan Webb dan.webb@damacus.io

@damacus damacus requested a review from a team as a code owner December 10, 2024 15:49
@damacus damacus requested a review from Copilot December 10, 2024 15:49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (4)

resources/container.rb:331

  • The single quote at the end of the comment should be a backtick for consistency.
# Tag will be:   `latest'

resources/container.rb:335

  • The single quote at the end of the comment should be a backtick for consistency.
# Tag will be:   `3.1'

resources/container.rb:343

  • The single quote at the end of the comment should be a backtick for consistency.
# Tag will be:   `3.1'

resources/container.rb:549

  • Ensure that there are tests covering the new GPU support behavior.
config['HostConfig']['DeviceRequests'] = [{
@damacus
Copy link
Member Author

damacus commented Dec 10, 2024

@alappe can you take this for a spin for us please.

Signed-off-by: Dan Webb <dan.webb@damacus.io>
@damacus damacus self-assigned this Dec 10, 2024
@damacus damacus added the Release: Minor Release to Chef Supermarket as a minor release when merged label Dec 10, 2024
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
@alappe
Copy link

alappe commented Dec 11, 2024

Hello @damacus

works perfectly – thank you very much!

Best regards
Andreas

@damacus damacus merged commit d62eec5 into main Dec 11, 2024
52 of 53 checks passed
@damacus damacus deleted the 1285 branch December 11, 2024 13:00
@kitchen-porter
Copy link
Contributor

Released as: 11.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants