Fix issue with container network mode causing unnecessary redeployment #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t when using `container:<name>` format - Added network mode normalization to handle container IDs consistently - Prevents container recreation when only the container ID format changes Signed-off-by: Dan Webb <dan.webb@damacus.io>
damacus
added
the
Release: Patch
damacus
changed the title
container:<name> format
Contributor
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 suggestions.
Comments skipped due to low confidence (2)
libraries/helpers_network.rb:24
- [nitpick] The method name 'normalize_network_mode' is too generic. Consider renaming it to 'normalize_container_network_mode' to better reflect its specific purpose.
def normalize_network_mode(mode)
resources/container.rb:750
- [nitpick] The method name normalize_network_mode is ambiguous. Consider renaming it to something more specific like normalize_container_network_mode to avoid confusion with the similarly named method in helpers_network.rb.
def normalize_network_mode(value)
|
Released as: 11.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1273